chia7712 merged PR #15924:
URL: https://github.com/apache/kafka/pull/15924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chiacyu commented on code in PR #15924:
URL: https://github.com/apache/kafka/pull/15924#discussion_r1641899702
##
core/src/main/scala/kafka/server/AclApis.scala:
##
@@ -69,7 +69,7 @@ class AclApis(authHelper: AuthHelper,
case Some(auth) =>
val filter = describeAc
chiacyu commented on PR #15924:
URL: https://github.com/apache/kafka/pull/15924#issuecomment-2171689757
Hi, @chia7712
Thanks for the reminder. Since we change the parameter of `aclsResources()`
then we can modify it into `aclsResources(auth.acls(filter))`. Then we can
remove the `return
chia7712 commented on PR #15924:
URL: https://github.com/apache/kafka/pull/15924#issuecomment-2167621969
@chiacyu any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
showuon commented on code in PR #15924:
URL: https://github.com/apache/kafka/pull/15924#discussion_r1609187500
##
core/src/main/scala/kafka/server/AclApis.scala:
##
@@ -69,7 +69,7 @@ class AclApis(authHelper: AuthHelper,
case Some(auth) =>
val filter = describeAc
chia7712 commented on code in PR #15924:
URL: https://github.com/apache/kafka/pull/15924#discussion_r1597473046
##
clients/src/main/java/org/apache/kafka/common/requests/DescribeAclsResponse.java:
##
@@ -137,15 +138,15 @@ public static List
aclBindings(List resources)
chia7712 commented on PR #15924:
URL: https://github.com/apache/kafka/pull/15924#issuecomment-2105945126
https://github.com/apache/kafka/blob/643db430a707479c9e87eec1ad67e1d4f43c9268/core/src/main/scala/kafka/server/AclApis.scala#L72
@chiacyu we don't need to collect all items to a ne
chiacyu opened a new pull request, #15924:
URL: https://github.com/apache/kafka/pull/15924
This pr reduced the occurrence of collection copy when generating
DescribeAclsResource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
