omkreddy merged PR #16488:
URL: https://github.com/apache/kafka/pull/16488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on code in PR #16488:
URL: https://github.com/apache/kafka/pull/16488#discussion_r147719
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -808,8 +808,6 @@ void shareAcknowledgement() {
void recordAcknowledgement(b
apoorvmittal10 commented on code in PR #16488:
URL: https://github.com/apache/kafka/pull/16488#discussion_r124001
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -696,4 +722,99 @@ public ShareFetchPartitionData(FetchParams fetchParams,
String grou
AndrewJSchofield commented on code in PR #16488:
URL: https://github.com/apache/kafka/pull/16488#discussion_r1666543803
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -696,4 +722,99 @@ public ShareFetchPartitionData(FetchParams fetchParams,
String gr
AndrewJSchofield commented on code in PR #16488:
URL: https://github.com/apache/kafka/pull/16488#discussion_r1666522093
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -696,4 +722,99 @@ public ShareFetchPartitionData(FetchParams fetchParams,
String gr