Re: [PR] KAFKA-16754: Implemented release acquired records functionality to SharePartition [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16430: URL: https://github.com/apache/kafka/pull/16430#discussion_r1651002843 ## checkstyle/suppressions.xml: ## @@ -39,6 +39,7 @@ + Review Comment: actually I had refactored and reduced the complexity in one of my

Re: [PR] KAFKA-16754: Implemented release acquired records functionality to SharePartition [kafka]

2024-06-24 Thread via GitHub
apoorvmittal10 commented on code in PR #16430: URL: https://github.com/apache/kafka/pull/16430#discussion_r1650900179 ## checkstyle/suppressions.xml: ## @@ -39,6 +39,7 @@ + Review Comment: Can we reduce the cyclomatic complexity? I have refactored acquire