soarez merged PR #16232:
URL: https://github.com/apache/kafka/pull/16232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
soarez commented on PR #16232:
URL: https://github.com/apache/kafka/pull/16232#issuecomment-2156032172
@showuon thank you for reviewing this.
Failed tests pass locally, and are unrelated to this change:
* KAFKA-16383
org.apache.kafka.connect.mirror.integration.IdentityReplicati
showuon commented on code in PR #16232:
URL: https://github.com/apache/kafka/pull/16232#discussion_r1630923359
##
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##
@@ -310,12 +313,21 @@ void testOnCompletion() throws Exception {
}
private s
showuon commented on PR #16232:
URL: https://github.com/apache/kafka/pull/16232#issuecomment-2154256928
Will check it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
soarez commented on PR #16232:
URL: https://github.com/apache/kafka/pull/16232#issuecomment-2154254709
@showuon could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
