Re: [PR] KAFKA-16890: Update log-start-offset monotonically when deleting overlapping remote segments [kafka]

2024-06-08 Thread via GitHub
chia7712 commented on code in PR #16237: URL: https://github.com/apache/kafka/pull/16237#discussion_r1632043139 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -954,7 +953,9 @@ public boolean isSegmentBreachedByRetentionTime(RemoteLogSegmentMetadata metadat

Re: [PR] KAFKA-16890: Update log-start-offset monotonically when deleting overlapping remote segments [kafka]

2024-06-07 Thread via GitHub
kamalcph commented on PR #16237: URL: https://github.com/apache/kafka/pull/16237#issuecomment-2154450697 @dopuskh3 Call for review. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] KAFKA-16890: Update log-start-offset monotonically when deleting overlapping remote segments [kafka]

2024-06-07 Thread via GitHub
kamalcph opened a new pull request, #16237: URL: https://github.com/apache/kafka/pull/16237 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade note