dopuskh3 opened a new pull request, #16210:
URL: https://github.com/apache/kafka/pull/16210
Avoid taking the active segment into account in RemoteCopyLagSegment metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r1627809909
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -842,7 +842,7 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long nextSegment
dopuskh3 commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r1627848696
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -842,7 +842,7 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long nextSegment
kamalcph commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2156632862
@dopuskh3
Any updates on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dopuskh3 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2156696910
> @dopuskh3
>
> Any updates on this?
Should be able to give it a try tomorrow. Pulling the fix on our internal
branch right now.
--
This is an automated message from
dopuskh3 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2156701940
@kamalcph updated test case. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
chia7712 commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r163401
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1018,8 +1018,8 @@ void testRemoteLogManagerRemoteMetrics() throws Exception
{
dopuskh3 commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r1636127214
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1018,8 +1018,8 @@ void testRemoteLogManagerRemoteMetrics() throws Exception
{
kamalcph commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r1636623718
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1000,7 +1000,7 @@ void testRemoteLogManagerRemoteMetrics() throws Exception
{
when
kamalcph commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r1636623718
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1000,7 +1000,7 @@ void testRemoteLogManagerRemoteMetrics() throws Exception
{
when
kamalcph commented on code in PR #16210:
URL: https://github.com/apache/kafka/pull/16210#discussion_r1637834169
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -1000,7 +1000,7 @@ void testRemoteLogManagerRemoteMetrics() throws Exception
{
when
dopuskh3 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2165134757
Updated tests according feedback @kamalcph PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kamalcph commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2167137194
Test failures are unrelated. The failed test is an existing flaky one:
```
testCorrectnessForCacheAndIndexFilesWhenResizeCache() –
kafka.log.remote.RemoteIndexCacheTest
```
chia7712 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2167190716
@dopuskh3 could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dopuskh3 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2168265370
@chia7712 fixed conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
chia7712 merged PR #16210:
URL: https://github.com/apache/kafka/pull/16210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2169017877
@dopuskh3 thanks for you contribution and @kamalcph thanks for your great
reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
17 matches
Mail list logo
