chia7712 merged PR #16341:
URL: https://github.com/apache/kafka/pull/16341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on PR #16341:
URL: https://github.com/apache/kafka/pull/16341#issuecomment-2171409206
Hi @chia7712, I addressed all comments. May you take a look? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1641733994
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1641733405
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TimeIndexTest.java:
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1641732520
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
FrankYang0529 commented on PR #16341:
URL: https://github.com/apache/kafka/pull/16341#issuecomment-2171005260
Hi @chia7712, I remove `assertDoesNotThrow` for function call, but keep it
if it's in lambda. Thanks for the suggestion.
--
This is an automated message from the Apache Git Servic
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1641587051
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
FrankYang0529 commented on PR #16341:
URL: https://github.com/apache/kafka/pull/16341#issuecomment-2169880348
Hi @chia7712, thanks for the review. I address all comments. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1640577317
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TimeIndexTest.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
FrankYang0529 opened a new pull request, #16341:
URL: https://github.com/apache/kafka/pull/16341
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
10 matches
Mail list logo
