chia7712 merged PR #16227:
URL: https://github.com/apache/kafka/pull/16227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2161999580
Hi @chia7712, I have do some small changes based on your feedback, PTAL 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1635735059
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,153 @@
import org.apache.kafka.common.record.TimestampType;
i
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1635734783
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,153 @@
import org.apache.kafka.common.record.TimestampType;
i
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1635380850
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,153 @@
import org.apache.kafka.common.record.TimestampType;
imp
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2159863343
Hi @chia7712, I have do a small change based on your feedback, PTAL 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1634144659
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,155 @@
import org.apache.kafka.common.record.TimestampType;
i
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1634004534
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,155 @@
import org.apache.kafka.common.record.TimestampType;
imp
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2157060477
Hi @chia7712 , I have do some changes and add a test case, PTAL 🐧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632484396
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
i
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632484236
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
i
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632481576
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
i
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632355536
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
imp
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2156349665
Hi @chia7712 , I have do some refactors, PTAL 🐧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632067288
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +38,109 @@ public class ConsumerRecordsTest {
@Test
publi
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2156063782
Hi @chia7712 , I do some changes based on comments, PTAL 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632055803
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632043299
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632040486
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
publ
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632032964
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -35,28 +35,83 @@ public class ConsumerRecordsTest {
@Test
public
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2155814048
Hi @chia7712, I do few changes based on comments, PTAL 🐧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1631833896
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -59,4 +49,72 @@ public void iterator() throws Exception {
}
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1631832885
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -59,4 +49,72 @@ public void iterator() throws Exception {
}
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1631832337
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -59,4 +49,72 @@ public void iterator() throws Exception {
}
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1631754807
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -59,4 +49,72 @@ public void iterator() throws Exception {
}
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2154878391
Hi @chia7712, I have modified the test case to cover the scenario of
multiple topics and records, PLTA 😺
--
This is an automated message from the Apache Git Service.
To respond to th
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1630620777
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -59,4 +50,47 @@ public void iterator() throws Exception {
}
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1629889551
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -59,4 +50,47 @@ public void iterator() throws Exception {
}
frankvicky opened a new pull request, #16227:
URL: https://github.com/apache/kafka/pull/16227
Add unit tests for `ConsumerRecords#records(String)`.
This commit adds new unit tests to the ConsumerRecordsTest class. One of the
tests validates that an IllegalArgumentException occurs when
29 matches
Mail list logo
