Re: [PR] KAFKA-16920: close BrokerLifecycleManager in tests [kafka]

2024-06-08 Thread via GitHub
soarez merged PR #16252: URL: https://github.com/apache/kafka/pull/16252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16920: close BrokerLifecycleManager in tests [kafka]

2024-06-08 Thread via GitHub
gaurav-narula commented on PR #16252: URL: https://github.com/apache/kafka/pull/16252#issuecomment-2156087544 Thanks for the feedback! Force pushed a commit with your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] KAFKA-16920: close BrokerLifecycleManager in tests [kafka]

2024-06-08 Thread via GitHub
gaurav-narula opened a new pull request, #16252: URL: https://github.com/apache/kafka/pull/16252 Tests in BrokerLifecycleManagerTest do not close BrokerLifecycleManager if an assertion fails. This change ensures `manager.close()` is always invoked in a finally block thereby preventing poten