chia7712 merged PR #16350:
URL: https://github.com/apache/kafka/pull/16350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
frankvicky commented on PR #16350:
URL: https://github.com/apache/kafka/pull/16350#issuecomment-2173322889
Hi @chia7712, I have make some changes based on feedback, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on code in PR #16350:
URL: https://github.com/apache/kafka/pull/16350#discussion_r1642307332
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java:
##
@@ -17,161 +17,156 @@
package
frankvicky commented on PR #16350:
URL: https://github.com/apache/kafka/pull/16350#issuecomment-2171124111
Hi @chia7712, I have make some changes based on your example to keep
`StandaloneHerderTest` has minimum changes during migration, PTAL
--
This is an automated message from the
chia7712 commented on code in PR #16350:
URL: https://github.com/apache/kafka/pull/16350#discussion_r1641453002
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -147,7 +147,7 @@
import static
frankvicky commented on PR #16350:
URL: https://github.com/apache/kafka/pull/16350#issuecomment-2169426511
Hi @chia7712 , @m1a2st
I have do some changes, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
frankvicky commented on code in PR #16350:
URL: https://github.com/apache/kafka/pull/16350#discussion_r1640916109
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/SynchronizationTest.java:
##
@@ -113,19 +111,14 @@ public synchronized void clear() {
m1a2st commented on code in PR #16350:
URL: https://github.com/apache/kafka/pull/16350#discussion_r1640841663
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -352,4 +373,4 @@ public int hashCode() {
return
chia7712 commented on code in PR #16350:
URL: https://github.com/apache/kafka/pull/16350#discussion_r1640826948
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedConfigTest.java:
##
@@ -43,18 +43,18 @@
import static
frankvicky opened a new pull request, #16350:
URL: https://github.com/apache/kafka/pull/16350
Migrate test of connect module to Junit5
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
10 matches
Mail list logo
