satishd commented on PR #16321:
URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167776223
Merged to 3.8 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jlprat commented on PR #16321:
URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167758040
Yes it is fine to add to the 3.8 branch. Can you cherry pick this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
satishd commented on PR #16321:
URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167183730
@jlprat This is a bug fix that addresses having a wrong metric in edge case
scenarios. It is good to have it merged in 3.8 too. Let me know if you are
fine with adding it as part of 3.8
satishd merged PR #16321:
URL: https://github.com/apache/kafka/pull/16321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kamalcph commented on PR #16321:
URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167136261
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
satishd commented on code in PR #16321:
URL: https://github.com/apache/kafka/pull/16321#discussion_r1637927805
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -431,11 +431,11 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
leader
dopuskh3 commented on code in PR #16321:
URL: https://github.com/apache/kafka/pull/16321#discussion_r1637908258
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -3014,6 +3014,28 @@ public void testCopyThrottling() throws Exception {
assertEquals(9
kamalcph commented on code in PR #16321:
URL: https://github.com/apache/kafka/pull/16321#discussion_r1637920257
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -3014,6 +3014,28 @@ public void testCopyThrottling() throws Exception {
assertEquals(9
kamalcph commented on PR #16321:
URL: https://github.com/apache/kafka/pull/16321#issuecomment-2164410837
@dopuskh3
Call for review. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kamalcph opened a new pull request, #16321:
URL: https://github.com/apache/kafka/pull/16321
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade note
10 matches
Mail list logo
