[PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-13 Thread via GitHub
rodesai opened a new pull request, #16337: URL: https://github.com/apache/kafka/pull/16337 Each KafkaStreams instance maintains a map from threadId to state to use to aggregate to a KafkaStreams app state. The map is updated on every state change, and when a new thread is created. State cha

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-13 Thread via GitHub
mjsax commented on code in PR #16337: URL: https://github.com/apache/kafka/pull/16337#discussion_r1639096220 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -635,14 +634,10 @@ public void setStandbyUpdateListener(final StandbyUpdateListener standbyLis

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-13 Thread via GitHub
rodesai commented on code in PR #16337: URL: https://github.com/apache/kafka/pull/16337#discussion_r1639348243 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -635,14 +634,10 @@ public void setStandbyUpdateListener(final StandbyUpdateListener standbyL

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-14 Thread via GitHub
mjsax commented on code in PR #16337: URL: https://github.com/apache/kafka/pull/16337#discussion_r1640160017 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -635,14 +634,10 @@ public void setStandbyUpdateListener(final StandbyUpdateListener standbyLis

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-14 Thread via GitHub
mjsax merged PR #16337: URL: https://github.com/apache/kafka/pull/16337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-07-07 Thread via GitHub
mjsax commented on PR #16337: URL: https://github.com/apache/kafka/pull/16337#issuecomment-2212782921 > Oh nevermind, 3.8 release is still ongoing duh. Need to wait for it to finish before backporting this. Yes. Also not sure how severe this one is? Might also be not the end of the w