Re: [PR] KAFKA-16989: Use StringBuilder instead of String concatenation [kafka]

2024-06-21 Thread via GitHub
chia7712 merged PR #16385: URL: https://github.com/apache/kafka/pull/16385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16989: Use StringBuilder instead of String concatenation [kafka]

2024-06-18 Thread via GitHub
frankvicky commented on PR #16385: URL: https://github.com/apache/kafka/pull/16385#issuecomment-2176349274 Hi @chia7712 , I have make a small change based on feedback, PTAL 😺 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-16989: Use StringBuilder instead of String concatenation [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on code in PR #16385: URL: https://github.com/apache/kafka/pull/16385#discussion_r1644605641 ## metadata/src/main/java/org/apache/kafka/image/node/ClientQuotasImageNode.java: ## @@ -127,20 +127,20 @@ static ClientQuotaEntity decodeEntity(String input) {

[PR] KAFKA-16989: Use StringBuilder instead of String concatenation [kafka]

2024-06-18 Thread via GitHub
frankvicky opened a new pull request, #16385: URL: https://github.com/apache/kafka/pull/16385 Currently, the String concatenation in `ClientQuotasImageNode` might be a heavy cost, so it should be replace with `StringBuilder` ### Committer Checklist (excluded from commit message) -