Re: [PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-07 Thread via GitHub
chia7712 merged PR #16524: URL: https://github.com/apache/kafka/pull/16524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-05 Thread via GitHub
brandboat commented on code in PR #16524: URL: https://github.com/apache/kafka/pull/16524#discussion_r1667247308 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -213,82 +214,151 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-05 Thread via GitHub
brandboat commented on code in PR #16524: URL: https://github.com/apache/kafka/pull/16524#discussion_r1667234615 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -213,82 +214,151 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-05 Thread via GitHub
chia7712 commented on code in PR #16524: URL: https://github.com/apache/kafka/pull/16524#discussion_r1667195347 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -213,82 +214,151 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-05 Thread via GitHub
brandboat commented on code in PR #16524: URL: https://github.com/apache/kafka/pull/16524#discussion_r1666951993 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -213,82 +214,151 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-04 Thread via GitHub
chia7712 commented on code in PR #16524: URL: https://github.com/apache/kafka/pull/16524#discussion_r1665921015 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -213,82 +214,151 @@ public class GroupCoordinatorConfig {

[PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-04 Thread via GitHub
brandboat opened a new pull request, #16524: URL: https://github.com/apache/kafka/pull/16524 related to https://issues.apache.org/jira/browse/KAFKA-17081 address comments in https://github.com/apache/kafka/pull/16458#issuecomment-220683 ### Committer Checklist (excluded fro