chia7712 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1685502849
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffse
junrao commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1685498438
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffset)
chia7712 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1685352004
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffse
junrao commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1684592601
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffset)
FrankYang0529 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1684321413
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long end
chia7712 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683662367
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffse
ocadaruma commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683644380
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffs
ocadaruma commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683651048
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffs
ocadaruma commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683651048
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffs
junrao commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683646397
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffset)
ocadaruma commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683644380
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffs
ocadaruma commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683644380
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffs
ocadaruma commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683644380
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffs
showuon commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683634531
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffset
chia7712 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683591221
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffse
junrao commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1683340380
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -348,7 +348,8 @@ public void truncateFromEndAsyncFlush(long endOffset)
chia7712 commented on PR #16614:
URL: https://github.com/apache/kafka/pull/16614#issuecomment-2236188569
@ocadaruma please feel free to raise objection as follow-up. It causes our
CI hanging, so I merge it for now.
--
This is an automated message from the Apache Git Service.
To respond to
chia7712 merged PR #16614:
URL: https://github.com/apache/kafka/pull/16614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16614:
URL: https://github.com/apache/kafka/pull/16614#issuecomment-2235710106
@ocadaruma could you please take a look? I prefer to modify the production
code to fix the deadlock in testing, because this solution is simple and make
sense to me.
--
This i
FrankYang0529 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1682150630
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -957,6 +957,17 @@ class LogManagerTest {
val topicPartition = UnifiedLog.parseTopicPartit
FrankYang0529 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1682150630
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -957,6 +957,17 @@ class LogManagerTest {
val topicPartition = UnifiedLog.parseTopicPartit
chia7712 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1682085510
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -957,6 +957,17 @@ class LogManagerTest {
val topicPartition = UnifiedLog.parseTopicPartitionNa
chia7712 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1681099940
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -957,6 +957,17 @@ class LogManagerTest {
val topicPartition = UnifiedLog.parseTopicPartitionNa
FrankYang0529 opened a new pull request, #16614:
URL: https://github.com/apache/kafka/pull/16614
In LogManagerTest#testLogRecoveryMetrics, add some delay to create second
UnifiedLog to avoid deadlock.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and im
24 matches
Mail list logo