Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

chia7712 merged PR #16638: URL: https://github.com/apache/kafka/pull/16638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

TaiJuWu commented on PR #16638: URL: https://github.com/apache/kafka/pull/16638#issuecomment-2246655210 > @TaiJuWu please use the new helper to rewrite > > https://github.com/apache/kafka/blob/c71eb60a3b2e30cc376b81144cf9c2c411d8f28b/clients/src/test/java/org/apache/kafka/clients/cons

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

chia7712 commented on PR #16638: URL: https://github.com/apache/kafka/pull/16638#issuecomment-2245651512 @TaiJuWu please use the new helper to rewrite https://github.com/apache/kafka/blob/c71eb60a3b2e30cc376b81144cf9c2c411d8f28b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaCo

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

TaiJuWu commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1687898103 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2970,28 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol g

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

TaiJuWu commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1687892353 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2976,21 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol g

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

lianetm commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1686689029 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2093,14 +2093,27 @@ public void testEndOffsetsAuthenticationFailure(GroupProt

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

lianetm commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1686689029 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2093,14 +2093,27 @@ public void testEndOffsetsAuthenticationFailure(GroupProt

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

lianetm commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1686692620 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2976,21 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol g

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

lianetm commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1686693862 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3399,4 +3424,11 @@ public void configure(Map configs) { CLIENT_I

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

lianetm commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1686692620 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2976,21 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol g

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

lianetm commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1686689029 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2093,14 +2093,27 @@ public void testEndOffsetsAuthenticationFailure(GroupProt

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

lianetm commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1686665604 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -862,7 +862,7 @@ public void testFetchProgressWithMissingPartitionPosition(Gro

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

chia7712 commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1685701571 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2976,21 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

TaiJuWu commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1685589970 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2976,21 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol g

Re: [PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

chia7712 commented on code in PR #16638: URL: https://github.com/apache/kafka/pull/16638#discussion_r1685477697 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2965,7 +2976,21 @@ public void testSubscriptionOnInvalidTopic(GroupProtocol

[PR] KAFKA-17163:revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure [kafka]

TaiJuWu opened a new pull request, #16638: URL: https://github.com/apache/kafka/pull/16638 *More detailed description of your change, See [KAFKA-17163](https://issues.apache.org/jira/browse/KAFKA-17163) *Summary of testing strategy (including rationale) ### Committer Checklis