Re: [PR] KAFKA-8735: Check properties file existence first [kafka]

2024-06-03 Thread via GitHub
qinghui-xu commented on PR #7139: URL: https://github.com/apache/kafka/pull/7139#issuecomment-2144362990 It turns out the patch is no more relevant with the refactorings in recent versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-8735: Check properties file existence first [kafka]

2024-06-03 Thread via GitHub
qinghui-xu closed pull request #7139: KAFKA-8735: Check properties file existence first URL: https://github.com/apache/kafka/pull/7139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-8735: Check properties file existence first [kafka]

2024-04-05 Thread via GitHub
qinghui-xu commented on PR #7139: URL: https://github.com/apache/kafka/pull/7139#issuecomment-2039564348 For me this should be merged even just for the sake of the codebase sanity. I can try to rebase it and resolve the conflict to update the PR. -- This is an automated message from

Re: [PR] KAFKA-8735: Check properties file existence first [kafka]

2024-04-04 Thread via GitHub
thaumatoast commented on PR #7139: URL: https://github.com/apache/kafka/pull/7139#issuecomment-2038272787 I'm currently facing this issue (and not mixing versions). This appears to be a bug regardless of version mixing, is there a reason not to merge this? -- This is an automated message