Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-29 Thread via GitHub
mjsax closed pull request #14446: KIP-759: new DSL operation on KStreams interface URL: https://github.com/apache/kafka/pull/14446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-29 Thread via GitHub
mjsax commented on PR #14446: URL: https://github.com/apache/kafka/pull/14446#issuecomment-2084319053 Closing this PR. Replace by #15740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-16 Thread via GitHub
LQXshane commented on code in PR #14446: URL: https://github.com/apache/kafka/pull/14446#discussion_r1568199337 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final Va

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-16 Thread via GitHub
LQXshane commented on code in PR #14446: URL: https://github.com/apache/kafka/pull/14446#discussion_r1568199214 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final Va

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-16 Thread via GitHub
LQXshane commented on code in PR #14446: URL: https://github.com/apache/kafka/pull/14446#discussion_r1568198123 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final Va

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-16 Thread via GitHub
LQXshane commented on PR #14446: URL: https://github.com/apache/kafka/pull/14446#issuecomment-2060317790 @mjsax It's Shay. Taking this one up from my personal account. My personal account don't have the permission to push to the other account, is it okay to create a new PR here https://gith

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-16 Thread via GitHub
LQXshane commented on code in PR #14446: URL: https://github.com/apache/kafka/pull/14446#discussion_r1568173605 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final Va

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-04-16 Thread via GitHub
LQXshane commented on code in PR #14446: URL: https://github.com/apache/kafka/pull/14446#discussion_r1568173605 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final Va

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-01-31 Thread via GitHub
lqxshay commented on PR #14446: URL: https://github.com/apache/kafka/pull/14446#issuecomment-1919417410 @mjsax gentle nudge on this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2024-01-21 Thread via GitHub
github-actions[bot] commented on PR #14446: URL: https://github.com/apache/kafka/pull/14446#issuecomment-1903103195 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KIP-759: new DSL operation on KStreams interface [kafka]

2023-10-20 Thread via GitHub
lqxshay commented on PR #14446: URL: https://github.com/apache/kafka/pull/14446#issuecomment-1773472492 Ran a couple of failed tests in my local - they look good, like @mjsax suggested it might be a set of flakey tests. -- This is an automated message from the Apache Git Service. To resp