Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-07-10 Thread via GitHub
mjsax commented on code in PR #15740: URL: https://github.com/apache/kafka/pull/15740#discussion_r1671646367 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -796,7 +797,6 @@ public KGroupedStream groupBy(final KeyValueMapper

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-07-10 Thread via GitHub
mjsax commented on PR #15740: URL: https://github.com/apache/kafka/pull/15740#issuecomment-2219658049 Btw: you should rebase your PR. The build failed with `Execution failed for task ':streams:spotlessJavaCheck'.` due to changes in `trunk` that you should pickup and fix your PR to make it

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-07-10 Thread via GitHub
mjsax commented on PR #15740: URL: https://github.com/apache/kafka/pull/15740#issuecomment-2219637356 One more thing: we should also update `docs/streams/upgrade.html` (just listing the KIP in the 3.9 upgrade section -- this section might not yet existing, so just add it for this case) and

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-07-10 Thread via GitHub
mjsax commented on code in PR #15740: URL: https://github.com/apache/kafka/pull/15740#discussion_r1671666407 ## streams/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java: ## @@ -439,6 +439,87 @@ public void

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-06-23 Thread via GitHub
LQXshane commented on code in PR #15740: URL: https://github.com/apache/kafka/pull/15740#discussion_r1650219136 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1616,4 +1623,25 @@ public KStream processValues(

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-06-23 Thread via GitHub
LQXshane commented on code in PR #15740: URL: https://github.com/apache/kafka/pull/15740#discussion_r1650218909 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -685,6 +685,41 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-06-23 Thread via GitHub
LQXshane commented on code in PR #15740: URL: https://github.com/apache/kafka/pull/15740#discussion_r1650214064 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -222,21 +226,21 @@ public KStream selectKey(final KeyValueMapper

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-06-23 Thread via GitHub
LQXshane commented on code in PR #15740: URL: https://github.com/apache/kafka/pull/15740#discussion_r1650128875 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -222,21 +226,21 @@ public KStream selectKey(final KeyValueMapper

Re: [PR] KIP-759 Mark as Partitioned [kafka]

2024-04-30 Thread via GitHub
mjsax commented on code in PR #15740: URL: https://github.com/apache/kafka/pull/15740#discussion_r1585886754 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -685,6 +685,41 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final

[PR] KIP-759 Mark as Partitioned [kafka]

2024-04-16 Thread via GitHub
LQXshane opened a new pull request, #15740: URL: https://github.com/apache/kafka/pull/15740 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of