Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

scholzj commented on PR #14756: URL: https://github.com/apache/kafka/pull/14756#issuecomment-1825984878 Thanks a lot for your help with this @mimaison and @viktorsomogyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

viktorsomogyi merged PR #14756: URL: https://github.com/apache/kafka/pull/14756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

viktorsomogyi commented on PR #14756: URL: https://github.com/apache/kafka/pull/14756#issuecomment-1825833128 There were failing unit tests but rerunning them locally from the PR they all passed, therefore they're likely unrelated flakies. Merging the PR, thanks @scholzj for the

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

mimaison commented on PR #14756: URL: https://github.com/apache/kafka/pull/14756#issuecomment-1824617646 @viktorsomogyi Do you have any further comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

scholzj commented on PR #14756: URL: https://github.com/apache/kafka/pull/14756#issuecomment-1823431704 Thanks for the review comments @viktorsomogyi. They should be now fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

viktorsomogyi commented on code in PR #14756: URL: https://github.com/apache/kafka/pull/14756#discussion_r1400948591 ## clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java: ## @@ -185,6 +188,18 @@ private SslEngineFactory createNewSslEngineFactory(Map

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

scholzj commented on code in PR #14756: URL: https://github.com/apache/kafka/pull/14756#discussion_r1394966608 ## clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java: ## @@ -185,6 +188,18 @@ private SslEngineFactory createNewSslEngineFactory(Map

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

mimaison commented on PR #14756: URL: https://github.com/apache/kafka/pull/14756#issuecomment-1812934459 @viktorsomogyi @omkreddy You also voted on the KIP. Do you want to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

mimaison commented on code in PR #14756: URL: https://github.com/apache/kafka/pull/14756#discussion_r1394485129 ## clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java: ## @@ -185,6 +188,18 @@ private SslEngineFactory createNewSslEngineFactory(Map

[PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

scholzj opened a new pull request, #14756: URL: https://github.com/apache/kafka/pull/14756 This PR implements [KIP-978: Allow dynamic reloading of certificates with different DN / SANs](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263429128). It adds two new options