C0urante commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1785353764
@kumarpritam863 I understand that the code changes are small, and I'm glad
to hear that pre-prod testing indicates that this commit has the intended
effect. However, I still think that u
kumarpritam863 commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1782659721
@C0urante
As I mentioned this is a very small change just a change in the order of
calling the same function which updates the partition count. This involves
practically no cod
C0urante commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1782075383
I can take a look next week. In the meantime, do you think you could add
some unit tests for this change?
--
This is an automated message from the Apache Git Service.
To respond to the
kumarpritam863 commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1781649825
@C0urante
It's a small but important modification, just a change in the order of
calling the UpdatePartitionCount method and practically involve no code change.
I kindly requ
kumarpritam863 commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1780668877
> @kumarpritam863 is this the same as #12622 and
https://issues.apache.org/jira/browse/KAFKA-14220? And if so, can you shed some
light on why that PR and ticket were wiped and clos
C0urante commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1779644800
@kumarpritam863 is this the same as
https://github.com/apache/kafka/pull/12622 and
https://issues.apache.org/jira/browse/KAFKA-14220?
--
This is an automated message from the Apache G
kumarpritam863 commented on PR #14630:
URL: https://github.com/apache/kafka/pull/14630#issuecomment-1778892134
@C0urante Can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kumarpritam863 opened a new pull request, #14630:
URL: https://github.com/apache/kafka/pull/14630
* In ICR(Incremental Cooperative Rebalancing) mode, whenever a new worker,
say Worker 3 joins, a new global assignment is computed by the leader, say
Worker1, that results in the revocation of
