Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-04 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2036758667 > have delayed backporting either change to 3.6 as we're currently in an ongoing release. If you'd like me to backport it now, I can do that. That makes sense. Let's wait for the R

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2035199919 Hi @chia7712 @omkreddy I have delayed backporting either change to 3.6 as we're currently in an ongoing release. If you'd like me to backport it now, I can do that. -- This is an a

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2035163301 @gharris1727 @omkreddy #15597 and this one have backported to 3.7. see https://github.com/apache/kafka/commit/d9674c6c9a99c0d8a9c32386b0cceaceac92969c and https://github.com/apa

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2034976891 I'll handle the backports later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
omkreddy commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2034952210 lets also merge to 3.7 and 3.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2034397405 ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful :connect:runtime:test --tests org.apache.kafka.connect.integration.ExactlyOnc

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-03 Thread via GitHub
chia7712 merged PR #15639: URL: https://github.com/apache/kafka/pull/15639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2032377734 > We should prioritize https://issues.apache.org/jira/browse/KAFKA-6527 to re-enable this test, as it would have caught this regression. sounds good to me. just test it on my local

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2032352619 Hi @chia7712 This [test is disabled in CI](https://github.com/apache/kafka/blob/ee61bb721eecb0404929f125fe43392f3d024453/core/src/test/scala/integration/kafka/server/DynamicBrokerRecon

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2031262693 @gharris1727 just curious. How do you notice that incorrect changes? Are there failed tests related to #15597? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-01 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2030593772 cc @mimaison @C0urante @OmniaGM @omkreddy PTAL, Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-01 Thread via GitHub
gharris1727 opened a new pull request, #15639: URL: https://github.com/apache/kafka/pull/15639 Revert some parts of the previous cleanup which were unnecessary and incorrect. Should accompany #15597 everywhere. ### Committer Checklist (excluded from commit message) - [ ] Ver