jlprat merged PR #15272:
URL: https://github.com/apache/kafka/pull/15272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jlprat commented on PR #15272:
URL: https://github.com/apache/kafka/pull/15272#issuecomment-1919044644
I checked that all tests pass locally, and the failures in CI seem all
unrelated to the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jlprat commented on PR #15272:
URL: https://github.com/apache/kafka/pull/15272#issuecomment-1916746800
Rebased again to contain https://github.com/apache/kafka/pull/15290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jlprat commented on PR #15272:
URL: https://github.com/apache/kafka/pull/15272#issuecomment-1916544246
Needed to rebase because of merge conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jlprat commented on code in PR #15272:
URL: https://github.com/apache/kafka/pull/15272#discussion_r1469806761
##
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##
@@ -50,6 +50,10 @@ trait AutoTopicCreationManager {
object AutoTopicCreationManager {
+ /**
mimaison commented on code in PR #15272:
URL: https://github.com/apache/kafka/pull/15272#discussion_r1469799402
##
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##
@@ -50,6 +50,10 @@ trait AutoTopicCreationManager {
object AutoTopicCreationManager {
+
jlprat commented on PR #15272:
URL: https://github.com/apache/kafka/pull/15272#issuecomment-1912344480
@showuon if you have some time, this is a follow up of the one you reviewed
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
jlprat commented on code in PR #15272:
URL: https://github.com/apache/kafka/pull/15272#discussion_r1467861593
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -80,7 +80,7 @@ object BrokerMetadataPublisher extends Logging {
jlprat opened a new pull request, #15272:
URL: https://github.com/apache/kafka/pull/15272
Follow up from https://github.com/apache/kafka/pull/15252
Mark methods and fields private where possible:
- Annotate public methods and fields
- Remove unused classes and methods
- Make
