chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518692934
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
ijuma commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518680219
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
}
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518650602
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
ijuma commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1518649065
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
}
chia7712 merged PR #15289:
URL: https://github.com/apache/kafka/pull/15289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gaurav-narula commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1516589314
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1516374859
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -195,6 +195,25 @@ public static File tempDirectory() {
return tempDirectory(null);
gaurav-narula commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1516017140
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1511231627
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
gaurav-narula commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1511199142
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
chia7712 commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1511059328
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,9 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
gaurav-narula commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1507510343
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,18 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
soarez commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1489605994
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,18 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
gaurav-narula commented on PR #15289:
URL: https://github.com/apache/kafka/pull/15289#issuecomment-1917579474
Addressed in
[4406670](https://github.com/apache/kafka/pull/15289/commits/4406670459210eb7fac009c836288955c7bcb23c)
> Shouldn't we instead update the tests to use temp
14 matches
Mail list logo
