Re: [PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]

2024-01-11 Thread via GitHub
dajac merged PR #15173: URL: https://github.com/apache/kafka/pull/15173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]

2024-01-11 Thread via GitHub
dajac commented on PR #15173: URL: https://github.com/apache/kafka/pull/15173#issuecomment-1887121573 Indeed, null is valid. Empty string is also valid but deprecated. Here I only want to ensure that we don't use it with the new protocol now. We strengthen the validation on the client in 4.

Re: [PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]

2024-01-11 Thread via GitHub
divijvaidya commented on PR #15173: URL: https://github.com/apache/kafka/pull/15173#issuecomment-1887118525 Perhaps we need a ConfigValidator whcih says NullOrNonEmptyString. We could have used that validator here. https://github.com/apache/kafka/blob/dba789dc93d8dee2965ea41df49f0c981f5dfa6

[PR] MINOR: Disalow using a group id with only whitespaces in the new consumer group protocol [kafka]

2024-01-11 Thread via GitHub
dajac opened a new pull request, #15173: URL: https://github.com/apache/kafka/pull/15173 This patch strengthen the validation of the group id when the new consumer group protocol is used. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation