mjsax merged PR #14540:
URL: https://github.com/apache/kafka/pull/14540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14540:
URL: https://github.com/apache/kafka/pull/14540#discussion_r1363144968
##
tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java:
##
@@ -290,7 +290,7 @@ record = new ProducerRecord<>(topic, key, value);
}
}
-
mjsax commented on code in PR #14540:
URL: https://github.com/apache/kafka/pull/14540#discussion_r1363143859
##
connect/api/src/main/java/org/apache/kafka/connect/health/ConnectClusterDetails.java:
##
@@ -27,6 +27,6 @@ public interface ConnectClusterDetails {
* Get the
jlprat commented on code in PR #14540:
URL: https://github.com/apache/kafka/pull/14540#discussion_r1362019221
##
connect/api/src/main/java/org/apache/kafka/connect/health/ConnectClusterDetails.java:
##
@@ -27,6 +27,6 @@ public interface ConnectClusterDetails {
* Get the
mjsax commented on PR #14540:
URL: https://github.com/apache/kafka/pull/14540#issuecomment-1761790031
I would say yes -- does not hurt, and avoids IntelliJ warnings. I like to
get a green checkmark on files :)
--
This is an automated message from the Apache Git Service.
To respond to
cadonna commented on PR #14540:
URL: https://github.com/apache/kafka/pull/14540#issuecomment-1761496605
No javadocs are generated for non-public API and test classes. Do you still
want to refactor them?
--
This is an automated message from the Apache Git Service.
To respond to the
mjsax closed pull request #7034: MINOR: Do not end Javadoc comments with `**/`
URL: https://github.com/apache/kafka/pull/7034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mjsax commented on PR #7034:
URL: https://github.com/apache/kafka/pull/7034#issuecomment-1760629873
Closing this stale PR in favor of https://github.com/apache/kafka/pull/14540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax opened a new pull request, #14540:
URL: https://github.com/apache/kafka/pull/14540
Follow up to https://github.com/apache/kafka/pull/7034 that got abandoned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
