Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-04 Thread via GitHub
jolshan merged PR #14888: URL: https://github.com/apache/kafka/pull/14888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-04 Thread via GitHub
jolshan commented on PR #14888: URL: https://github.com/apache/kafka/pull/14888#issuecomment-1839165891 Given this change only affects this test and the test failures are known or unrelated, I will merge. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-04 Thread via GitHub
jolshan commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1414267284 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -134,6 +136,20 @@ public void testSecondaryR

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
splett2 commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1412729044 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -134,6 +136,20 @@ public void testSecondaryR

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
splett2 commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1412729044 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -134,6 +136,20 @@ public void testSecondaryR

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
splett2 commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1412729044 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -134,6 +136,20 @@ public void testSecondaryR

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
kirktrue commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1412678216 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -134,6 +136,20 @@ public void testSecondary

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
jolshan commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r141264 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -134,6 +136,20 @@ public void testSecondaryR

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
jolshan commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1412620108 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -62,14 +62,14 @@ public class RefreshingHttp

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
ashwinpankaj commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1411942462 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -62,14 +62,14 @@ public class Refreshin

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
ashwinpankaj commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1411930564 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -62,14 +62,14 @@ public class Refreshin

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-12-01 Thread via GitHub
ashwinpankaj commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1411930564 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -62,14 +62,14 @@ public class Refreshin

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-11-30 Thread via GitHub
splett2 commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1411492950 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -62,14 +62,14 @@ public class RefreshingHttp

[PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-11-30 Thread via GitHub
splett2 opened a new pull request, #14888: URL: https://github.com/apache/kafka/pull/14888 ### What This test is flaky because `maybeExpediteRefresh` schedules a refresh in a background thread. Instead pass through a mock executor service so that the refresh is executed directly.