Re: [PR] MINOR: Fix the flaky TBRLMM `testInternalTopicExists` test [kafka]

2023-11-28 Thread via GitHub
showuon merged PR #14840: URL: https://github.com/apache/kafka/pull/14840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Fix the flaky TBRLMM `testInternalTopicExists` test [kafka]

2023-11-28 Thread via GitHub
junrao commented on code in PR #14840: URL: https://github.com/apache/kafka/pull/14840#discussion_r1408122036 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -70,18 +70,20 @@ public

Re: [PR] MINOR: Fix the flaky TBRLMM `testInternalTopicExists` test [kafka]

2023-11-27 Thread via GitHub
showuon commented on code in PR #14840: URL: https://github.com/apache/kafka/pull/14840#discussion_r1407350742 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -70,18 +70,20 @@ public

Re: [PR] MINOR: Fix the flaky TBRLMM `testInternalTopicExists` test [kafka]

2023-11-27 Thread via GitHub
kamalcph commented on code in PR #14840: URL: https://github.com/apache/kafka/pull/14840#discussion_r1407187421 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -70,18 +70,20 @@ public

Re: [PR] MINOR: Fix the flaky TBRLMM `testInternalTopicExists` test [kafka]

2023-11-27 Thread via GitHub
junrao commented on code in PR #14840: URL: https://github.com/apache/kafka/pull/14840#discussion_r1406631952 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -70,18 +70,20 @@ public

Re: [PR] MINOR: Fix the flaky TBRLMM `testInternalTopicExists` test [kafka]

2023-11-27 Thread via GitHub
kamalcph commented on PR #14840: URL: https://github.com/apache/kafka/pull/14840#issuecomment-1827599944 > Sorry, if this is an internal topic why do you need to explicitly initialise it? Could you give me a bit of context on the proposed solution? The internal topic creation is

[PR] MINOR: Fix the flaky TBRLMM `testInternalTopicExists` test [kafka]

2023-11-24 Thread via GitHub
kamalcph opened a new pull request, #14840: URL: https://github.com/apache/kafka/pull/14840 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade