jolshan commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492801866
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) throws
dajac commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492992453
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) throws
rreddy-22 commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492848158
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) thro
rreddy-22 commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492844519
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) thro
rreddy-22 commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492799701
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) thro
jolshan commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492801866
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) throws
rreddy-22 commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492799701
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) thro
jolshan commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492798225
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) throws
rreddy-22 commented on code in PR #15382:
URL: https://github.com/apache/kafka/pull/15382#discussion_r1492788275
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) thro
nizhikov commented on PR #15382:
URL: https://github.com/apache/kafka/pull/15382#issuecomment-1948181817
Hello, @dajac I will take a look, shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac opened a new pull request, #15382:
URL: https://github.com/apache/kafka/pull/15382
While reviewing https://github.com/apache/kafka/pull/15150, I found that our
tests verifying the console output are really hard to read. Here is my proposal
to make it better.
### Committer Check
dajac commented on PR #15382:
URL: https://github.com/apache/kafka/pull/15382#issuecomment-1948168236
@mimaison @nizhikov @rreddy-22 @jolshan Could you take a look when you get a
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
12 matches
Mail list logo