Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-27 Thread via GitHub
wolfchimneyrock commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1783465122 > @wolfchimneyrock Thanks again for the PR. We verified and your suggestion makes sense. I have two asks: > > 1. Could you please file a bug and use the the jira id in the

Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-27 Thread via GitHub
dajac commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1783402130 @wolfchimneyrock Thanks again for the PR. We verified and your suggestion makes sense. I have two asks: 1) Could you please file a bug and use the the jira id in the PR? 2) Would it

Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-26 Thread via GitHub
dajac commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1781346471 Thanks @wolfchimneyrock. We will take a look into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-25 Thread via GitHub
wolfchimneyrock commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1779515287 Here is a broker trace: ``` [2023-10-24 01:17:17,214] ERROR [KafkaApi-28598] Unexpected error handling request RequestHeader(apiKey=LEAVE_GROUP, apiVersion=1,

Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-25 Thread via GitHub
wolfchimneyrock commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1779439685 I'm not sure I can elaborate on what the underlying error response that would have been sent with the LeaveGroup is, since the current code raises that exception without

Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-25 Thread via GitHub
wolfchimneyrock commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1779425711 > @wolfchimneyrock Thanks for the PR. I am not to fully understand the issue yet. Could you please elaborate a bit more about the condition leading to it? there is more

Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-25 Thread via GitHub
dajac commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1779417281 @wolfchimneyrock Thanks for the PR. I am not to fully understand the issue yet. Could you please elaborate a bit more about the condition leading to it? -- This is an automated message

[PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-25 Thread via GitHub
wolfchimneyrock opened a new pull request, #14635: URL: https://github.com/apache/kafka/pull/14635 KIP-848 introduced this check, but we have seen since upgrading to broker 3.4 with both Sarama and Librdkafka clients when issuing LeaveGroup and getting an error, the single member gets lost