Re: [PR] MINOR: Move related getters to RemoteLogManagerConfig [kafka]

2024-07-07 Thread via GitHub
kamalcph commented on PR #16538: URL: https://github.com/apache/kafka/pull/16538#issuecomment-2212967033 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] MINOR: Move related getters to RemoteLogManagerConfig [kafka]

2024-07-07 Thread via GitHub
chia7712 merged PR #16538: URL: https://github.com/apache/kafka/pull/16538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Move related getters to RemoteLogManagerConfig [kafka]

2024-07-06 Thread via GitHub
brandboat commented on PR #16538: URL: https://github.com/apache/kafka/pull/16538#issuecomment-2211728398 gentle ping @chia7712 , @kamalcph. Could you take a look when you are available ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] MINOR: Move related getters to RemoteLogManagerConfig [kafka]

2024-07-05 Thread via GitHub
brandboat opened a new pull request, #16538: URL: https://github.com/apache/kafka/pull/16538 there are two RemoteLogManagerConfig-related getters `logLocalRetentionBytes` `logLocalRetentionMs` which still remain in KafkaConfig, this pr move them to RemoteLogManagerConfig. ### Committ