ijuma commented on PR #15430:
URL: https://github.com/apache/kafka/pull/15430#issuecomment-1975916553
Unrelated to this PR, but the description of the class calls it `concurrent`
while we seem to acquire locks during the operations. Perhaps thread-safe is a
better description for what's hap
dajac merged PR #15430:
URL: https://github.com/apache/kafka/pull/15430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1504266300
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -53,53 +50,19 @@
@Timeout(value = 60)
public
dajac commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1504265561
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/EventAccumulator.java:
##
@@ -137,31 +136,43 @@ public void add(T event) throws
RejectedExe
jolshan commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1503400099
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/EventAccumulator.java:
##
@@ -137,31 +136,43 @@ public void add(T event) throws
RejectedE
jeffkbkim commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1503398332
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/EventAccumulator.java:
##
@@ -137,31 +136,43 @@ public void add(T event) throws
Rejecte
jeffkbkim commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1503396742
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -53,53 +50,19 @@
@Timeout(value = 60)
pu
jolshan commented on PR #15430:
URL: https://github.com/apache/kafka/pull/15430#issuecomment-1965265194
Left one question -- otherwise lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
jolshan commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1503291909
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -53,53 +50,19 @@
@Timeout(value = 60)
publ
jolshan commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1503073175
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/EventAccumulator.java:
##
@@ -137,31 +136,43 @@ public void add(T event) throws
RejectedE
dajac opened a new pull request, #15430:
URL: https://github.com/apache/kafka/pull/15430
`poll(long timeout, TimeUnit unit)` is either used with `Long.MAX_VALUE` or
`0`. This patch replaces it with `poll` and `take`. It removes the `awaitNanos`
usage.
### Committer Checklist (exclude
11 matches
Mail list logo
