Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-08 Thread via GitHub
lucasbru merged PR #15874: URL: https://github.com/apache/kafka/pull/15874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-08 Thread via GitHub
lucasbru commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099949443 https://confluent-kafka-branch-builder-system-test-results-v2.s3-us-west-2.amazonaws.com/trunk/2024-05-07--001./report.html -- This is an automated message from the Apache Git

Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-07 Thread via GitHub
mjsax commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099036837 Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder-test/20/ -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-07 Thread via GitHub
lucasbru commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2097704867 @mjsax It does change, because we need to keep a list of tests (with parameters) that do not work with ARM. The `from_version` parameter does not change, because only old versions are

Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-06 Thread via GitHub
mjsax commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2097231440 Thanks for the PR. Makes sense. What I don't fully understand is, what you mean by `This simplifies testing downstream, since the test parameters do not change with every version.`

[PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-06 Thread via GitHub
lucasbru opened a new pull request, #15874: URL: https://github.com/apache/kafka/pull/15874 In two streams tests, we are using the current snapshot version as a test parameter `to_version`, but as the only option. We can hardcode it. This simplifies testing downstream, since the test