dajac commented on PR #16233:
URL: https://github.com/apache/kafka/pull/16233#issuecomment-2158213759
Merged to trunk and to 3.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dajac merged PR #16233:
URL: https://github.com/apache/kafka/pull/16233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on PR #16233:
URL: https://github.com/apache/kafka/pull/16233#issuecomment-2156005210
@dajac Could you please rebase code to include #16249?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
chia7712 commented on PR #16233:
URL: https://github.com/apache/kafka/pull/16233#issuecomment-2155659562
I have re-trigger QA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dajac commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1631215048
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogenousAssignmentBuilder.java:
##
@@ -48,7 +48,7 @@
* The assignment builder pr
chia7712 commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1631152083
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogenousAssignmentBuilder.java:
##
@@ -48,7 +48,7 @@
* The assignment builder
dajac commented on PR #16233:
URL: https://github.com/apache/kafka/pull/16233#issuecomment-2154626099
Thanks, @rreddy-22. I addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dajac commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1631048997
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
Review Comment:
Yeah, I prefer removing it b
rreddy-22 commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1630244033
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
Review Comment:
Do we wanna get rid of t
rreddy-22 commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1630235368
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##
@@ -77,13 +77,13 @@ public GroupAssignment assign(
if
rreddy-22 commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1630233896
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##
@@ -46,8 +46,8 @@
*
* The appropriate strategy is automati
dajac opened a new pull request, #16233:
URL: https://github.com/apache/kafka/pull/16233
This patch renames the uniform assignor's builders to match the
`SubscriptionType` which is used to determine which one is called. It also
applies minor refactoring.
### Committer Checklist (excl
12 matches
Mail list logo
