hachikuji merged PR #14697:
URL: https://github.com/apache/kafka/pull/14697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
hachikuji commented on PR #14697:
URL: https://github.com/apache/kafka/pull/14697#issuecomment-1819609057
@junrao I triggered a few builds and didn't see much consistency in the test
failures. I tried some of the tests locally and they passed. I will go ahead
and merge to trunk.
--
This
hachikuji commented on PR #14697:
URL: https://github.com/apache/kafka/pull/14697#issuecomment-1811585213
@ex172000 @junrao Thanks for reviewing. Please take another look when you
have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
hachikuji commented on code in PR #14697:
URL: https://github.com/apache/kafka/pull/14697#discussion_r1393453106
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -818,9 +818,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
appendInfo.setMaxTimestam
hachikuji commented on code in PR #14697:
URL: https://github.com/apache/kafka/pull/14697#discussion_r1393447344
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -399,12 +402,20 @@ class LogValidatorTest {
assertEquals(i, offsetCounter.value);
assert
junrao commented on code in PR #14697:
URL: https://github.com/apache/kafka/pull/14697#discussion_r1382110298
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -1641,7 +1659,7 @@ class LogValidatorTest {
}
}
- def verifyRecordConversionStats(stats: R
ex172000 commented on code in PR #14697:
URL: https://github.com/apache/kafka/pull/14697#discussion_r1381157089
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -399,12 +402,20 @@ class LogValidatorTest {
assertEquals(i, offsetCounter.value);
assertE
hachikuji opened a new pull request, #14697:
URL: https://github.com/apache/kafka/pull/14697
1. Set shallowOffsetOfMaxTimestamp consistently as the last offset in the
batch for v2 compressed and non-compressed data.
2. Rename `RecordConversionStats` to `RecordValidationStats` since one of
