Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2024-02-16 Thread via GitHub
kirktrue closed pull request #14752: MINOR: WakeupTrigger cleanup URL: https://github.com/apache/kafka/pull/14752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2024-02-12 Thread via GitHub
github-actions[bot] commented on PR #14752: URL: https://github.com/apache/kafka/pull/14752#issuecomment-1940369577 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-14 Thread via GitHub
philipnee commented on PR #14752: URL: https://github.com/apache/kafka/pull/14752#issuecomment-1810767025 Hi @kirktrue Thanks for taking time to clean up the task. I left some comments there. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-14 Thread via GitHub
philipnee commented on code in PR #14752: URL: https://github.com/apache/kafka/pull/14752#discussion_r1392968241 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -24,85 +25,133 @@ import java.util.concurrent.atomic.AtomicReference;

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-14 Thread via GitHub
philipnee commented on code in PR #14752: URL: https://github.com/apache/kafka/pull/14752#discussion_r1392964486 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -24,85 +25,133 @@ import java.util.concurrent.atomic.AtomicReference;

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-14 Thread via GitHub
philipnee commented on code in PR #14752: URL: https://github.com/apache/kafka/pull/14752#discussion_r1392962733 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -24,85 +25,133 @@ import java.util.concurrent.atomic.AtomicReference;

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-13 Thread via GitHub
kirktrue commented on PR #14752: URL: https://github.com/apache/kafka/pull/14752#issuecomment-1809303495 @philipnee Would you tag this with `ctr` and review? This is a low priority clean up. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-13 Thread via GitHub
kirktrue opened a new pull request, #14752: URL: https://github.com/apache/kafka/pull/14752 Added comments, made package-visible, and removed inner interface and classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us