apoorvmittal10 commented on code in PR #16422:
URL: https://github.com/apache/kafka/pull/16422#discussion_r1650869359
##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -1513,7 +1513,7 @@ private Thread shutdownHelper(final boolean error, final
long timeoutMs, final b
}
stateDirectory.close();
- adminClient.close();
+ adminClient.close(Duration.ofMillis(timeoutMs));
Review Comment:
Query: Shouldn't we account the time already spent in closing processes i.e.
timeoutMs passed to different applications might not be just constant rather
decreasing? I have seen decreasing time approach in KafkaConsumer:
https://github.com/apache/kafka/blob/3a0c83e49030074271dd34c20fa99baad6270c93/clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java#L1141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
