jolshan merged PR #14753:
URL: https://github.com/apache/kafka/pull/14753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #14753:
URL: https://github.com/apache/kafka/pull/14753#issuecomment-1811575702
Given the scope of the change, these test failures are not related. Will
followup elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jolshan commented on code in PR #14753:
URL: https://github.com/apache/kafka/pull/14753#discussion_r1393093702
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -898,20 +900,19 @@ class ReplicaManager(val config: KafkaConfig,
}
actionQueue.add {
-
hachikuji commented on code in PR #14753:
URL: https://github.com/apache/kafka/pull/14753#discussion_r1392979091
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -898,20 +900,19 @@ class ReplicaManager(val config: KafkaConfig,
}
actionQueue.add {
-
jolshan commented on code in PR #14753:
URL: https://github.com/apache/kafka/pull/14753#discussion_r1392978203
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -813,7 +813,8 @@ class ReplicaManager(val config: KafkaConfig,
jolshan commented on code in PR #14753:
URL: https://github.com/apache/kafka/pull/14753#discussion_r1392953096
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -813,7 +813,8 @@ class ReplicaManager(val config: KafkaConfig,
artemlivshits commented on code in PR #14753:
URL: https://github.com/apache/kafka/pull/14753#discussion_r1392946436
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -813,7 +813,8 @@ class ReplicaManager(val config: KafkaConfig,
jolshan opened a new pull request, #14753:
URL: https://github.com/apache/kafka/pull/14753
In 91fa196930ece7342f38a5404…dfc09cf607916eb, I accidentally removed the
action queue paramater that was added in
7d147cf2413e5d361422728e5c9306574658c78d
I don't think this broke anything
