[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499849#comment-17499849 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang] Thanks for your reply. I will create a PR later,

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499791#comment-17499791 ] Guozhang Wang commented on KAFKA-13694: --- Actually my previous suggestion has a flaw: even when one

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499777#comment-17499777 ] Guozhang Wang commented on KAFKA-13694: --- [~RivenSun] I think that's a good point, I agree with you

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498734#comment-17498734 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang]  If we simply change to call

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498517#comment-17498517 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang]  Thanks for your reply, I agree with you totally. I

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498491#comment-17498491 ] Guozhang Wang commented on KAFKA-13694: --- Thanks [~RivenSun]. It looks like we are in agreement on

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498442#comment-17498442 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang]  Sorry, the version of KafkaProducer I read before

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498411#comment-17498411 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang] I looked at the code on the KafkaProducer side

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498369#comment-17498369 ] RivenSun commented on KAFKA-13694: -- Hi @guozhang wang,  I went through the code again. I agree with

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498364#comment-17498364 ] RivenSun commented on KAFKA-13694: -- Hi [~guozhang]  Thank you for your reply. The KafkaProducer code I

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498234#comment-17498234 ] Guozhang Wang commented on KAFKA-13694: --- Hello [~RivenSun] thanks for the report. If I understand

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497970#comment-17497970 ] RivenSun commented on KAFKA-13694: -- I studied the general flow of the generate class and found that I

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497941#comment-17497941 ] RivenSun commented on KAFKA-13694: -- And another question, for the class in the generated directory, do

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497940#comment-17497940 ] RivenSun commented on KAFKA-13694: -- Hi [~showuon]  , [~guozhang]  Could you give any suggestions?