[
https://issues.apache.org/jira/browse/KAFKA-15958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806412#comment-17806412
]
Apoorv Mittal commented on KAFKA-15958:
---------------------------------------
[~pnee] I have looked into the suggestion to use Parametrized Test to check
different versions but I don't see any benefit yet as the only version
supported is 0. The suggestion pointed to `HeartbeatRequestManagerTest` which
also just iterates on just 0 version occurrence yet and that's the same
behaviour is for telemetry requests test.
If the suggestion was to add this parametrized test so it could be the future
support when versions are incremented in telemetry requests then I think we
shall handle some checks according to incremented version and they would be
known once version is incremented, for example in `JoinGroupResponseTest.java`,
etc. Again I don't see any benefit making the tests for telemetry requests
Parametrized currently.
I am closing this ticket, please let me know if you think otherwise then we can
discuss further.
> Add tests to validate telemetry requests with different version
> ---------------------------------------------------------------
>
> Key: KAFKA-15958
> URL: https://issues.apache.org/jira/browse/KAFKA-15958
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Apoorv Mittal
> Assignee: Apoorv Mittal
> Priority: Major
>
> Details: https://github.com/apache/kafka/pull/14724#discussion_r1412530561
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
