[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2019-01-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736369#comment-16736369 ] Guozhang Wang commented on KAFKA-4468: -- With

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-09-01 Thread Richard Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151237#comment-16151237 ] Richard Yu commented on KAFKA-4468: --- [~bbejeck] [~guozhang] This commit seems to be ready for merging,

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-09-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150802#comment-16150802 ] Matthias J. Sax commented on KAFKA-4468: Seems like Bill is pretty responsive on the PR. :) I can

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-08-31 Thread Richard Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149830#comment-16149830 ] Richard Yu commented on KAFKA-4468: --- [~mjsax] Can you ask Bill to review my updates? Thanks. >

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-08-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146155#comment-16146155 ] Matthias J. Sax commented on KAFKA-4468: [~bbejeck] left already couple of comments. Please

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-08-28 Thread Richard Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144519#comment-16144519 ] Richard Yu commented on KAFKA-4468: --- [~mjsax] [~guozhang] : Can you review my pull request? Thanks. >

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142916#comment-16142916 ] ASF GitHub Bot commented on KAFKA-4468: --- GitHub user ConcurrencyPractitioner opened a pull request:

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-08-26 Thread Richard Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142877#comment-16142877 ] Richard Yu commented on KAFKA-4468: --- When looking through the references for Windowed Deserializer, it

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-07-20 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095793#comment-16095793 ] Guozhang Wang commented on KAFKA-4468: -- Even in PAPI, I think today we do not expose APIs for users

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-07-20 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095769#comment-16095769 ] Matthias J. Sax commented on KAFKA-4468: [~guozhang] We have to distinguish two cases: (1)

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-07-06 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076830#comment-16076830 ] Matthias J. Sax commented on KAFKA-4468: Thanks for following up. About storing the window size --

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-07-06 Thread Evgeny Veretennikov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076472#comment-16076472 ] Evgeny Veretennikov commented on KAFKA-4468: Let me show you such example: {code:java} final

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-07-06 Thread Evgeny Veretennikov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076373#comment-16076373 ] Evgeny Veretennikov commented on KAFKA-4468: Sorry, guys, I missed javadoc comment to

[jira] [Commented] (KAFKA-4468) Correctly calculate the window end timestamp after read from state stores

2017-06-29 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068935#comment-16068935 ] Matthias J. Sax commented on KAFKA-4468: [~evis] In