[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354546#comment-16354546
]
Guozhang Wang commented on KAFKA-4750:
--
As a summary of this resolution:
{code}
Here is the new rule
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349240#comment-16349240
]
ASF GitHub Bot commented on KAFKA-4750:
---
guozhangwang closed pull request #3430: KAFKA-4750:
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349235#comment-16349235
]
ASF GitHub Bot commented on KAFKA-4750:
---
guozhangwang opened a new pull request #4508: KAFKA-4750:
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098929#comment-16098929
]
Guozhang Wang commented on KAFKA-4750:
--
[~evis] That is right, we can go with the first option above.
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097368#comment-16097368
]
Matthias J. Sax commented on KAFKA-4750:
IMHO, we can also improve the code by not calling the
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097357#comment-16097357
]
Evgeny Veretennikov commented on KAFKA-4750:
So, to sum up discussion. I should close current
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095776#comment-16095776
]
Matthias J. Sax commented on KAFKA-4750:
I understand what you are saying, but encoding an empty
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094568#comment-16094568
]
Matthias J. Sax commented on KAFKA-4750:
As mentioned above. I would go with option (1) as null
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093595#comment-16093595
]
Bill Bejeck commented on KAFKA-4750:
Thanks for the clarification [~guozhang], my inclination is to go
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065155#comment-16065155
]
Guozhang Wang commented on KAFKA-4750:
--
[~evis] Inside RocksDB store, after the serialization, if we
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063956#comment-16063956
]
Matthias J. Sax commented on KAFKA-4750:
I think [~damianguy] or [~enothereska] can comment best
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062575#comment-16062575
]
Evgeny Veretennikov commented on KAFKA-4750:
If we invoke {{store.put(key, value)}}, and
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062423#comment-16062423
]
Matthias J. Sax commented on KAFKA-4750:
Sounds good to me.
> KeyValueIterator returns null
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062384#comment-16062384
]
Guozhang Wang commented on KAFKA-4750:
--
I think the Streams library should not assume that either 1)
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062112#comment-16062112
]
Matthias J. Sax commented on KAFKA-4750:
Your observation is correct. I simplified the call chain.
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061898#comment-16061898
]
Evgeny Veretennikov commented on KAFKA-4750:
[~mjsax], are you sure about call chain in
[
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061243#comment-16061243
]
Evgeny Veretennikov commented on KAFKA-4750:
I guess, problem lies in
17 matches
Mail list logo