[jira] [Commented] (KAFKA-5559) Metrics should throw if two client registers with same ID

2017-09-05 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154204#comment-16154204 ] Matthias J. Sax commented on KAFKA-5559: As discussed, I am closing this as "not an issue". We can

[jira] [Commented] (KAFKA-5559) Metrics should throw if two client registers with same ID

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154199#comment-16154199 ] ASF GitHub Bot commented on KAFKA-5559: --- Github user mjsax closed the pull request at:

[jira] [Commented] (KAFKA-5559) Metrics should throw if two client registers with same ID

2017-08-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135535#comment-16135535 ] Guozhang Wang commented on KAFKA-5559: -- Hi [~onurkaraman], thanks for the comments. Just want to

[jira] [Commented] (KAFKA-5559) Metrics should throw if two client registers with same ID

2017-08-18 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133274#comment-16133274 ] Onur Karaman commented on KAFKA-5559: - Hey [~guozhang]. I read through the PR. I actually had a very

[jira] [Commented] (KAFKA-5559) Metrics should throw if two client registers with same ID

2017-08-18 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133156#comment-16133156 ] Guozhang Wang commented on KAFKA-5559: -- [~onurkaraman] [~xiaotao183] There are some further

[jira] [Commented] (KAFKA-5559) Metrics should throw if two client registers with same ID

2017-08-17 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131513#comment-16131513 ] Onur Karaman commented on KAFKA-5559: - [~xiaotao183] I agree that as per the definition of