[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-09-08 Thread huxihx (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158229#comment-16158229 ] huxihx commented on KAFKA-5859: --- [~ijuma] Does appending `bodyAndSize = null` in RequestCha

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-09-08 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158279#comment-16158279 ] Ismael Juma commented on KAFKA-5859: The idea is not to store `bodyAndSize`, not mutat

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-09-08 Thread huxihx (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158316#comment-16158316 ] huxihx commented on KAFKA-5859: --- `bodyAndSize` holds the parsed request instance and size. I

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-09-08 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158330#comment-16158330 ] Ismael Juma commented on KAFKA-5859: As stated in the JIRA description, we only need `

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-09-11 Thread huxihx (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160838#comment-16160838 ] huxihx commented on KAFKA-5859: --- [~ijuma] Seems `updateRequestMetrics` in `RequestChannel.Re

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-09-28 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184419#comment-16184419 ] Ismael Juma commented on KAFKA-5859: [~huxi_2b], it needs needs the `ApiKeys` instance

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-10-29 Thread Sean Glover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224279#comment-16224279 ] Sean Glover commented on KAFKA-5859: Hey [~ijuma]. I've been analyzing the work requi

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252935#comment-16252935 ] ASF GitHub Bot commented on KAFKA-5859: --- GitHub user seglo opened a pull request:

[jira] [Commented] (KAFKA-5859) Avoid retaining AbstractRequest in RequestChannel.Request

2017-11-14 Thread Sean Glover (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252936#comment-16252936 ] Sean Glover commented on KAFKA-5859: I've submitted a PR for this ticket. See descrip