[ https://issues.apache.org/jira/browse/KAFKA-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172201#comment-16172201 ]
ASF GitHub Bot commented on KAFKA-5933: --------------------------------------- GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3908 KAFKA-5933: Move timeout and validate_only protocol fields into CommonFields class Most of the fields which are shared by multiple protocol messages (requests ad responses) are in the CommonFields class. However there are still some fields used multiple times which are not there yet: * `timeout` * `validate_only` It would be good to move also these two fields into the CommonFields class so that they can be easily shared by different messages. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka common-fields Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3908.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3908 ---- commit 2772267e213e17bc04032d7305db3099ad0d573d Author: Jakub Scholz <w...@scholzj.com> Date: 2017-09-19T19:04:45Z Move timeout and validate_only to CommonFields ---- > Move timeout and validate_only protocol fields into CommonFields class > ---------------------------------------------------------------------- > > Key: KAFKA-5933 > URL: https://issues.apache.org/jira/browse/KAFKA-5933 > Project: Kafka > Issue Type: Bug > Reporter: Jakub Scholz > > Most of the fields which are shared by multiple protocol messages (requests > ad responses) are in the CommonFields class. However there are still some > fields used multiple times which are not there yet: > * timeout > * validate_only > It would be good to move also these two fields into the CommonFields class so > that they can be easily shared by different messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)