[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-03-09 Thread John Roesler (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393587#comment-16393587 ] John Roesler commented on KAFKA-6535: - I don't think it's that important in this context, but it's

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-03-09 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393457#comment-16393457 ] Matthias J. Sax commented on KAFKA-6535: Yes. It's a long though (not and integer). We should pass

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-03-09 Thread Khaireddine Rezgui (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392692#comment-16392692 ] Khaireddine Rezgui commented on KAFKA-6535: --- Infinity == Integer.MAX_VALUE ? [~mjsax] > Set

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-02-12 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361495#comment-16361495 ] Matthias J. Sax commented on KAFKA-6535: Ok. Sounds good. There are couple of other scenarios,

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361490#comment-16361490 ] Guozhang Wang commented on KAFKA-6535: -- I think it may be brining more operational risk than benefit

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-02-07 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356231#comment-16356231 ] Matthias J. Sax commented on KAFKA-6535: So you don't think that adding a "config" to the API

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-02-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356140#comment-16356140 ] Guozhang Wang commented on KAFKA-6535: -- I see you point now. And yes, I agree that we could improve

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-02-06 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354610#comment-16354610 ] Matthias J. Sax commented on KAFKA-6535: I don't think we should do this by default. I am just

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-02-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354548#comment-16354548 ] Guozhang Wang commented on KAFKA-6535: -- I think we cannot safely do that for user topics, since these

[jira] [Commented] (KAFKA-6535) Set default retention ms for Streams repartition topics to infinity

2018-02-05 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353244#comment-16353244 ] Matthias J. Sax commented on KAFKA-6535: Meta comment: sometimes, people need to manually