[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-07-19 Thread Attila Sasvari (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549082#comment-16549082 ] Attila Sasvari commented on KAFKA-6884: --- pull request was merged, thanks for the reviews! >

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-15 Thread Attila Sasvari (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476020#comment-16476020 ] Attila Sasvari commented on KAFKA-6884: --- - tests that verify timeouts pass after making some changes

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-15 Thread Attila Sasvari (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475751#comment-16475751 ] Attila Sasvari commented on KAFKA-6884: --- Thanks [~hachikuji]. I have seen the pull request was

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-11 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472117#comment-16472117 ] Jason Gustafson commented on KAFKA-6884: Thanks [~asasvari]. I think the assignment strategy is

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-11 Thread Attila Sasvari (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472041#comment-16472041 ] Attila Sasvari commented on KAFKA-6884: --- It seems assignmentStrategy is also needed. Added some new

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-11 Thread Attila Sasvari (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471932#comment-16471932 ] Attila Sasvari commented on KAFKA-6884: --- [~hachikuji] Thanks, I downloaded the pull request as a

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-10 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470728#comment-16470728 ] Jason Gustafson commented on KAFKA-6884: [~asasvari] Yes, you are right. [~cmccabe] submitted a

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-10 Thread Attila Sasvari (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470680#comment-16470680 ] Attila Sasvari commented on KAFKA-6884: --- [~hachikuji] thanks for the additional information! - I

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-09 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469197#comment-16469197 ] Jason Gustafson commented on KAFKA-6884: [~asasvari] Thanks for picking this up! Yes, we should

[jira] [Commented] (KAFKA-6884) ConsumerGroupCommand should use new AdminClient

2018-05-09 Thread Attila Sasvari (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468881#comment-16468881 ] Attila Sasvari commented on KAFKA-6884: --- [~hachikuji] consumer-groups.sh currently uses