[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-12-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715218#comment-16715218 ] ASF GitHub Bot commented on KAFKA-7549: --- hachikuji closed pull request #5925: KAFKA

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690978#comment-16690978 ] ASF GitHub Bot commented on KAFKA-7549: --- dongjinleekr opened a new pull request #59

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-09 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681948#comment-16681948 ] Jason Gustafson commented on KAFKA-7549: Sorry for the late response. As I unders

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-09 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681636#comment-16681636 ] Ismael Juma commented on KAFKA-7549: With regards to the actual error, there was a di

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-09 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681635#comment-16681635 ] Ismael Juma commented on KAFKA-7549: [~lindong] yeah, we can move this to 2.2.0 and 2

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-09 Thread Lee Dongjin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681617#comment-16681617 ] Lee Dongjin commented on KAFKA-7549: [~lindong] Well, it seems like the ProduceReques

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-08 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680509#comment-16680509 ] Dong Lin commented on KAFKA-7549: - [~ijuma] [~hachikuji] Given the reasoning provided abo

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-07 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678602#comment-16678602 ] Dong Lin commented on KAFKA-7549: - I actually think it is reasonable for client to receiv

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-11-05 Thread Lee Dongjin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676115#comment-16676115 ] Lee Dongjin commented on KAFKA-7549: [~ijuma]  [~hachikuji] Ping! > Old ProduceReque

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-10-29 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667272#comment-16667272 ] Ismael Juma commented on KAFKA-7549: [~edenhill], my comment was a response to the or

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-10-29 Thread Magnus Edenhill (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667263#comment-16667263 ] Magnus Edenhill commented on KAFKA-7549: Right, but the producer client will hope

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-10-29 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667190#comment-16667190 ] Ismael Juma commented on KAFKA-7549: The user never instantiates an invalid ProducerR

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-10-29 Thread Magnus Edenhill (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1859#comment-1859 ] Magnus Edenhill commented on KAFKA-7549: Even if option 2 is logically more corre

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-10-26 Thread Lee Dongjin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665396#comment-16665396 ] Lee Dongjin commented on KAFKA-7549: [~ijuma] I reviewed the problem. Here is the res

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-10-25 Thread Lee Dongjin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663865#comment-16663865 ] Lee Dongjin commented on KAFKA-7549: [~ijuma] No problem. Let me have a look. > Old

[jira] [Commented] (KAFKA-7549) Old ProduceRequest with zstd compression does not return error to client

2018-10-25 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663722#comment-16663722 ] Ismael Juma commented on KAFKA-7549: [~dongjin] would you have time to look into this