[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016395#comment-17016395 ] Matthias J. Sax commented on KAFKA-7591: SGTM. > Changelog retention period does

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016372#comment-17016372 ] Sophie Blee-Goldman commented on KAFKA-7591: That's fair, I suppose if it _wa

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016352#comment-17016352 ] Matthias J. Sax commented on KAFKA-7591: Personally, I don't see why updating the

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016294#comment-17016294 ] Sophie Blee-Goldman commented on KAFKA-7591: Right, that is why I say if we c

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015631#comment-17015631 ] Matthias J. Sax commented on KAFKA-7591: Yes, it would be a semantic issue. The i

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-14 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015513#comment-17015513 ] Sophie Blee-Goldman commented on KAFKA-7591: {quote}Shouldn't you need to res

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015502#comment-17015502 ] Matthias J. Sax commented on KAFKA-7591: {quote}Shouldn't you need to reset the a

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-14 Thread Jon Bates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015433#comment-17015433 ] Jon Bates commented on KAFKA-7591: -- Agreed! A WARN message could at least be picked up,

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2020-01-14 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015408#comment-17015408 ] Sophie Blee-Goldman commented on KAFKA-7591: Shouldn't you need to reset the

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2018-12-03 Thread John Roesler (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708021#comment-16708021 ] John Roesler commented on KAFKA-7591: - I looked into the code, and for reference, the

[jira] [Commented] (KAFKA-7591) Changelog retention period doesn't synchronise with window-store size

2018-11-05 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675529#comment-16675529 ] Matthias J. Sax commented on KAFKA-7591: I updated this a "improvement" as the de