[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752923#comment-16752923 ] ASF GitHub Bot commented on KAFKA-7837: --- junrao commented on pull request #6202: KAFKA-7837: Ensure

[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752790#comment-16752790 ] ASF GitHub Bot commented on KAFKA-7837: --- dhruvilshah3 commented on pull request #6202: KAFKA-7837:

[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751766#comment-16751766 ] Jun Rao commented on KAFKA-7837: [~dhruvilshah], the following is the description of the iterator of

[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-23 Thread Dhruvil Shah (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750805#comment-16750805 ] Dhruvil Shah commented on KAFKA-7837: - [~junrao] [~lindong] having looked a bit into this, it seems

[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-18 Thread Dhruvil Shah (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746588#comment-16746588 ] Dhruvil Shah commented on KAFKA-7837: - I could take a stab at fixing this. > maybeShrinkIsr may not

[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746520#comment-16746520 ] Jun Rao commented on KAFKA-7837: @lindong, yes, the approach that you described sounds good. >

[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-17 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745832#comment-16745832 ] Dong Lin commented on KAFKA-7837: - [~junrao] Currently `partition.maybeShrinkIsr(...)` reads

[jira] [Commented] (KAFKA-7837) maybeShrinkIsr may not reflect OfflinePartitions immediately

2019-01-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745680#comment-16745680 ] Jun Rao commented on KAFKA-7837: One way to improve this is that in maybeShrinkIsr(), for each iterated